[webkit-reviews] review granted: [Bug 16884] Circular Dependency
between PluginPackageWin and PluginDatabaseWin : [Attachment
18462] Updated patch to clean up as per comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 15 17:51:24 PST 2008
Jon Honeycutt <jhoneycutt at apple.com> has granted Rodney Dawes
<dobey at wayofthemonkey.com>'s request for review:
Bug 16884: Circular Dependency between PluginPackageWin and PluginDatabaseWin
http://bugs.webkit.org/show_bug.cgi?id=16884
Attachment 18462: Updated patch to clean up as per comments
http://bugs.webkit.org/attachment.cgi?id=18462&action=edit
------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
I think your ChangeLog entry could use some punctuation. I think you could also
put the Silverlight version constants inside the function body. Otherwise looks
great. Thanks for working on this!
r=me
More information about the webkit-reviews
mailing list