[webkit-reviews] review requested: [Bug 16868] Gmail crash : [Attachment 18458] Revised proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 15 08:47:16 PST 2008


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 16868: Gmail crash
http://bugs.webkit.org/show_bug.cgi?id=16868

Attachment 18458: Revised proposed patch
http://bugs.webkit.org/attachment.cgi?id=18458&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
This makes the marking non-recursive except in the case where m_savedExec is
actually different than m_callingExec. Instead of having the second loop, one
could simply change the first loop to set currentSavedExec to
currentCallingExec instead of breaking from the loop. I don't know if that is
too obfuscated for something so simple.


More information about the webkit-reviews mailing list