[webkit-reviews] review granted: [Bug 15195] KJSProxy::m_handlerLineno is not reset between page loads in some cases : [Attachment 18431] Reset KJSProxy::m_handlerLineno in KJSProxy::clear

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 15195: KJSProxy::m_handlerLineno is not reset between page loads in some
cases
http://bugs.webkit.org/show_bug.cgi?id=15195

Attachment 18431: Reset KJSProxy::m_handlerLineno in KJSProxy::clear
http://bugs.webkit.org/attachment.cgi?id=18431&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Here are some things I notice:

    1) XML doesn't set the line number at all while parsing.

    2) The functions to create event handlers should ask the document's
tokenizer what the current line number is, perhaps with a special function that
is specifically designed for event handlers, rather than storing a line number
inside the KJSProxy object, which seems upside down and backwards to me.

    3) Setting the line number back to 0 is OK, but really doesn't help all
that much.

r=me because there's little harm here. But I don't really like the idea of the
comment in KJSProxy::clear() mentioning FrameLoader::clear().