[webkit-reviews] review denied: [Bug 16848] SecurityOrigin::copy does not copy m_domainWasSetInDOM : [Attachment 18402] Fixes SecurityOrigin::copy method to copy the security origin

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied 's request for review:
Bug 16848: SecurityOrigin::copy does not copy m_domainWasSetInDOM
http://bugs.webkit.org/show_bug.cgi?id=16848

Attachment 18402: Fixes SecurityOrigin::copy method to copy the security origin
http://bugs.webkit.org/attachment.cgi?id=18402&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
After further scrutiny, there's another aspect of this patch that I'm not sure
about.

This removes the copy() calls on the protocol and host. Under normal
circumstances, copy() is not needed to copy a WebCore::String, but if we intend
to use the string on another thread, we do need a copy(). I'm not sure it's
safe to remove the copy() here, because I suspect that the caller does use this
on another thread.

We either need to prove those copies aren't needed, or create a new version of
this patch that retains the calls to copy().