[webkit-reviews] review denied: [Bug 16850] autotools derivedsources.make, proper shared lib, etc.. : [Attachment 18412] Updated patch to reuse DerivedSources.make

[bugzilla-daemon at webkit.org]

Alp Toker <alp at atoker.com> has denied Jan Alonzo <jmalonzo at gmail.com>'s request
for review:
Bug 16850: autotools derivedsources.make, proper shared lib, etc..
http://bugs.webkit.org/show_bug.cgi?id=16850

Attachment 18412: Updated patch to reuse DerivedSources.make
http://bugs.webkit.org/attachment.cgi?id=18412&action=edit

------- Additional Comments from Alp Toker <alp at atoker.com>
As discussed on IRC this isn't the right way to do things. I've enabled
-fvisibility=hidden and -fvisibility-inlines-hidden using libtool modules in
r29445.

We should aim to include DerivedSources.make, not invoke the make application
on it, as this would lose any benefits of integrating the two.