[webkit-reviews] review granted: [Bug 16765] Range does not adjust endContainer and endOffset correctly after insertNode (Acid3 bug) : [Attachment 18420] Fix Range.insertNode for the textSplit case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 13 08:14:25 PST 2008


Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 16765: Range does not adjust endContainer and endOffset correctly after
insertNode (Acid3 bug)
http://bugs.webkit.org/show_bug.cgi?id=16765

Attachment 18420: Fix Range.insertNode for the textSplit case
http://bugs.webkit.org/attachment.cgi?id=18420&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This is OK as far as it goes. But long term we need to adjust ranges for any
changes to the DOM, not just changes performed by the range code itself. We
need to register the ranges with the document and update them as the various
elements and text nodes are mutated. So more patches like this one are not a
step in the right direction.

Nonetheless, r=me


More information about the webkit-reviews mailing list