[webkit-reviews] review requested: [Bug 16856] Tests assume buggy javascript URL implementation : [Attachment 18410] Fixes wrong tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 12 13:28:45 PST 2008

Adam Barth <hk9565 at gmail.com> has asked  for review:
Bug 16856: Tests assume buggy javascript URL implementation

Attachment 18410: Fixes wrong tests

------- Additional Comments from Adam Barth <hk9565 at gmail.com>
These tests to not intend to replace the document when navigating to their
javascript URLs.  This patch wraps the calls in void, which always returns
undefined.  This also keeps the old version of image-map.html to retain a
regression test for Bug 16782, but maybe it should be turned into a reduced
test case for that bug.

More information about the webkit-reviews mailing list