[webkit-reviews] review denied: [Bug 16814] Give plugin a chance to handle ActiveX objects : [Attachment 18374] Patch for the proposed change

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 11 13:04:39 PST 2008

Anders Carlsson <andersca at apple.com> has denied Rui Jiang <rjiang at gmail.com>'s
request for review:
Bug 16814: Give plugin a chance to handle ActiveX objects

Attachment 18374: Patch for the proposed change

------- Additional Comments from Anders Carlsson <andersca at apple.com>
I like the general idea of this patch. However, it would be better if you could
check that a plug-in exists that can handle "application/x-oleobject" before
setting the service type. 

There is a PlugInInfoStore method called supportsMIMEType that can be used for
this. I don't think it has been implemented on Windows though, so you would
have to do that (just have it call PluginDatabaseWin::isMIMETypeRegistered).

Come to think of it, we might want to always check that there is a plug-in
available that supports a MIME type before mapping a classid to that MIME type.

More information about the webkit-reviews mailing list