[webkit-reviews] review denied: [Bug 16844] RenderText::addLineBoxRects erroneously includes last char for boundingBox : [Attachment 18397] Patch taking Peter's comments into account

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 11 11:52:05 PST 2008


Dave Hyatt <hyatt at apple.com> has denied Finnur Thorarinsson
<finnur.webkit at gmail.com>'s request for review:
Bug 16844: RenderText::addLineBoxRects erroneously includes last char for
boundingBox
http://bugs.webkit.org/show_bug.cgi?id=16844

Attachment 18397: Patch taking Peter's comments into account
http://bugs.webkit.org/attachment.cgi?id=18397&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
end() points to the last character in a run and not to the character after it.

The implementation of end():

unsigned end() const { return m_len ? m_start + m_len - 1 : m_start; }

I do not know why your particular test case is failing, but end() does point to
the last character.


More information about the webkit-reviews mailing list