[webkit-reviews] review cancelled: [Bug 16844] RenderText::addLineBoxRects erroneously includes last char for boundingBox : [Attachment 18396] Patch for the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 11 11:47:16 PST 2008


Finnur Thorarinsson <finnur.webkit at gmail.com> has cancelled Finnur Thorarinsson
<finnur.webkit at gmail.com>'s request for review:
Bug 16844: RenderText::addLineBoxRects erroneously includes last char for
boundingBox
http://bugs.webkit.org/show_bug.cgi?id=16844

Attachment 18396: Patch for the bug
http://bugs.webkit.org/attachment.cgi?id=18396&action=edit

------- Additional Comments from Finnur Thorarinsson <finnur.webkit at gmail.com>
I changed:

box->end() + 1 <= end	    to
box->end() < end

... and moved the comment in the else clause above the if (since it applies to
both the if clause and the else clause now).


More information about the webkit-reviews mailing list