[webkit-reviews] review requested: [Bug 16562] [gtk] Implement WebPolicyDelegate methods : [Attachment 18394] Applied comments and more

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 11 09:49:40 PST 2008


Pierre-Luc Beaudoin <pierre-luc.beaudoin at collabora.co.uk> has asked  for
review:
Bug 16562: [gtk] Implement WebPolicyDelegate methods
http://bugs.webkit.org/show_bug.cgi?id=16562

Attachment 18394: Applied comments and more
http://bugs.webkit.org/attachment.cgi?id=18394&action=edit

------- Additional Comments from Pierre-Luc Beaudoin
<pierre-luc.beaudoin at collabora.co.uk>
"100 fois sur le métier remettez votre travail" ;)

This version is more complete.	After reviewing Christian's comments, I figured
the patch was missing the action information from WebPolicyDelegates.  This
times, this patch includes it and in a way that the API won't break when we
fully support all other action information.  

I tested a little new-window-requested.  This event only happens on links with
a target.  I set it to the default ACCEPT, but there aren't any change on the
behavior.  So it is unimplemented.


More information about the webkit-reviews mailing list