[webkit-reviews] review requested: [Bug 16817] [Gtk] Menu items need underscores : [Attachment 18388] Add underscores to appropriate menu labels.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 11 04:21:09 PST 2008


Christian Dywan <christian at imendio.com> has asked  for review:
Bug 16817: [Gtk] Menu items need underscores
http://bugs.webkit.org/show_bug.cgi?id=16817

Attachment 18388: Add underscores to appropriate menu labels.
http://bugs.webkit.org/attachment.cgi?id=18388&action=edit

------- Additional Comments from Christian Dywan <christian at imendio.com>
This patch adds underscores to all appropriate menu labels.

-    return String::fromUTF8(_("No file selected"));
+    return String::fromUTF8(_("(None)"));

I changed this to match GtkFileChooserButton.

-    return String::fromUTF8(_("Search with MSN"));
+    return String::fromUTF8(_("_Search the Web"));

I changed this because I don't think a random search engine provider is very
useful in a generic item.


More information about the webkit-reviews mailing list