[webkit-reviews] review cancelled: [Bug 16562] [gtk] Implement WebPolicyDelegate methods : [Attachment 18372] Removed the fix

[bugzilla-daemon at webkit.org]

Christian Dywan <christian at imendio.com> has cancelled Pierre-Luc Beaudoin
<pierre-luc.beaudoin at collabora.co.uk>'s request for review:
Bug 16562: [gtk] Implement WebPolicyDelegate methods
http://bugs.webkit.org/show_bug.cgi?id=16562

Attachment 18372: Removed the fix 
http://bugs.webkit.org/attachment.cgi?id=18372&action=edit

------- Additional Comments from Christian Dywan <christian at imendio.com>
>+    g_print(" %d \n", response);

Better remove that.

>+bool FrameLoaderClient::canShowMIMEType(const String& type) const 
>+{ 
>+    // FIXME: add supported mimestypes of plugins

s/mimestypes/mimetypes

>+    g_print("DEBUG");

Better remove that as well.

>+static WebKitPolicyResponse
webkit_web_view_real_new_window_requested(WebKitWebView*, WebKitWebFrame*
frame, WebKitNetworkRequest*)
>+{
>+    notImplemented();
>+    // FIXME: Change this to accept once it is implemented

I wonder how that could be implemented at all. WebKit does not normally have
any idea what a 'window' is in the context of the client application.

>+     * WebKitWebView::new-window-requested:
>+     * @web_view: the object on which the signal is emitted
>+     * @web_frame: the frame on which the action 
>+     * @return: WEBKIT_POLICY_RESPONSE_ACCEPT to allow WebKit to display a
new window,
>+		  WEBKIT_POLICY_RESPONSE_IGNORE not to display a new window
>+     *
>+     * Decides whether or not to allow a targeted navigation event, such as
opening a link in a new window.
>+     * The default behavior is to accept.

The default behavior is to ignore the request.