[webkit-reviews] review requested: [Bug 16779] Make the PluginStream implementation be shared across platforms : [Attachment 18370] Updated patch to fix WebCore.pro and preserve history for the PluginStream code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 10 12:25:04 PST 2008


Rodney Dawes <dobey at wayofthemonkey.com> has asked  for review:
Bug 16779: Make the PluginStream implementation be shared across platforms
http://bugs.webkit.org/show_bug.cgi?id=16779

Attachment 18370: Updated patch to fix WebCore.pro and preserve history for the
PluginStream code
http://bugs.webkit.org/attachment.cgi?id=18370&action=edit

------- Additional Comments from Rodney Dawes <dobey at wayofthemonkey.com>
Here's an updated patch which adds PluginStream.cpp to WebCore.pro SOURCES, and
uses svn mv to preserve the history for PluginStreamWin as it is now named
PluginStream. This also fixes a build issue in the latest version where
npfunctions.h was including npruntime.h and npapi.h directly instead of
npruntime_internal.h, which is needed for building on X11.


More information about the webkit-reviews mailing list