[webkit-reviews] review requested: [Bug 16779] Make the
PluginStream implementation be shared across platforms :
[Attachment 18362] Updated patch that runs correctly on Windows
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 10 03:06:38 PST 2008
Mark Rowe (bdash) <mrowe at apple.com> has asked for review:
Bug 16779: Make the PluginStream implementation be shared across platforms
http://bugs.webkit.org/show_bug.cgi?id=16779
Attachment 18362: Updated patch that runs correctly on Windows
http://bugs.webkit.org/attachment.cgi?id=18362&action=edit
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
Fixed the crash. The file handle was not being initialized to a sane value so
it was being treated as valid when in fact it had not been opened. This lead
to a crash when the handle was closed.
While debugging this issue I noticed some coding style issues and took the
liberty of fixing them along with the crash.
More information about the webkit-reviews
mailing list