[webkit-reviews] review cancelled: [Bug 16562] [gtk] Implement WebPolicyDelegate methods : [Attachment 18276] Applied some comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 9 16:19:25 PST 2008

Pierre-Luc Beaudoin <pierre-luc.beaudoin at collabora.co.uk> has cancelled
Pierre-Luc Beaudoin <pierre-luc.beaudoin at collabora.co.uk>'s request for review:
Bug 16562: [gtk] Implement WebPolicyDelegate methods

Attachment 18276: Applied some comments

------- Additional Comments from Pierre-Luc Beaudoin
<pierre-luc.beaudoin at collabora.co.uk>
I changed _NULL to _ERROR for a more explicit signification and it matches

Also included: webkit_web_view_can_show_mime_type() which should be used by
policy handle to determine what to do with a MIME type.

I removed the signal handling in main.c as it didn't make much sens in this
patch.	Removing it made me discover a bug in RessourceHandleManager.  If a
ressource get a PolicyIgnore, Curl would crash as the easy handle would have
been cleaned up during its processing.	Using the delayed cancel for all jobs
solves this issue (said fix included in this patch).

More information about the webkit-reviews mailing list