[webkit-reviews] review denied: [Bug 16758] ASSERT when using TreeWalker methods for a current node outside of the root (Acid3) : [Attachment 18291] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied 's request for review:
Bug 16758: ASSERT when using TreeWalker methods for a current node outside of
the root (Acid3)
http://bugs.webkit.org/show_bug.cgi?id=16758

Attachment 18291: patch
http://bugs.webkit.org/attachment.cgi?id=18291&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This is wrong.

If you read the TreeWalker documentation, you'll see that it has well defined
behavior when used on nodes outside the original subtree. The code correctly
implemented most of those rules before -- this patch broke it!

I have a patch that fixes it. The test case expects behavior that is incorrect,
so I need to change it around.