[webkit-reviews] review requested: [Bug 16779] Make the PluginStream implementation be shared across platforms : [Attachment 18328] Updated patch to fix issues in previous review

[bugzilla-daemon at webkit.org]

Rodney Dawes <dobey at wayofthemonkey.com> has asked  for review:
Bug 16779: Make the PluginStream implementation be shared across platforms
http://bugs.webkit.org/show_bug.cgi?id=16779

Attachment 18328: Updated patch to fix issues in previous review
http://bugs.webkit.org/attachment.cgi?id=18328&action=edit

------- Additional Comments from Rodney Dawes <dobey at wayofthemonkey.com>
This patch resolves the #if 0'd code issue by implementing the
PluginStreamClient class, and updating PluginViewWin to inherit from it. It
also adds a deleteFile() call for platforms other than win32, to remove the
temp file. Win32 uses ::DeleteFileA for the temp file, while deleteFile uses
::DeleteFileW, so we use an #if PLATFORM(WIN) to call ::DeleteFileA, and call
deleteFile for other platforms.

Can someone please test that this patch builds and works on Win32? It needs to
be tested there before being landed. Thanks.