[webkit-reviews] review denied: [Bug 16779] Make the PluginStream implementation be shared across platforms : [Attachment 18323] Patch to implement shared PluginStream

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Rodney Dawes
<dobey at wayofthemonkey.com>'s request for review:
Bug 16779: Make the PluginStream implementation be shared across platforms
http://bugs.webkit.org/show_bug.cgi?id=16779

Attachment 18323: Patch to implement shared PluginStream
http://bugs.webkit.org/attachment.cgi?id=18323&action=edit

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
I love the direction this is heading in!  Two issues that I have noticed:  
+#if 0
+    if (!m_loadManually)
+	 m_pluginView->disconnectStream(this);
+#endif

I don't think this code can be omitted.  We don't land code with #if 0's in it
either.


And:
+#if PLATFORM(WIN)
+    if (!m_path.isNull())
+	 ::DeleteFileA(m_path.data());
+#endif

Looking at the code, this suggests that the file is only removed on Windows. 
The removal of the temporary file should also be abstracted into FileSystem.h
and called on all platforms.