[webkit-reviews] review requested: [Bug 15960] View source mode displays the attributes after an attribute with an empty value incorrectly. : [Attachment 18315] Proposed patch v4.1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 7 10:55:09 PST 2008


Anyang Ren <anyang.ren at gmail.com> has asked  for review:
Bug 15960: View source mode displays the attributes after an attribute with an
empty value incorrectly.
http://bugs.webkit.org/show_bug.cgi?id=15960

Attachment 18315: Proposed patch v4.1
http://bugs.webkit.org/attachment.cgi?id=18315&action=edit

------- Additional Comments from Anyang Ren <anyang.ren at gmail.com>
The only difference from patch v4 is to use 0 instead of NULL for null
pointers.

I think I can improve the patch more if I understand the code better. 
Specifically, I suspect that the condition
(token->attrs && currAttr < token->attrs->length()) must be true
because the guide string and the attribute array should be created
in sync in HTMLTokenizer.cpp; if the condition
(token->attrs && currAttr < token->attrs->length()) is false, I
believe it indicates a bug in HTMLTokenizer::parseTag().


More information about the webkit-reviews mailing list