[webkit-reviews] review denied: [Bug 16202] Optimize allocation of ActivationImp objects : [Attachment 18307] Revised proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 7 01:54:56 PST 2008


Maciej Stachowiak <mjs at apple.com> has denied Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 16202: Optimize allocation of ActivationImp objects
http://bugs.webkit.org/show_bug.cgi?id=16202

Attachment 18307: Revised proposed patch
http://bugs.webkit.org/attachment.cgi?id=18307&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I reviewed this. The style is looking pretty good, I made a few suggestions on
IRC.

The only showstopper is that this has a potential crashing bug when tearing off
an activation that is not the top opne (which can only happen when getting the
"arguments" property from a function object.


More information about the webkit-reviews mailing list