[webkit-reviews] review requested: [Bug 16731] Incorrect node type for whitespace when setting innerHTML in an XHTML document : [Attachment 18302] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 6 10:38:04 PST 2008


Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 16731: Incorrect node type for whitespace when setting innerHTML in an
XHTML document
http://bugs.webkit.org/show_bug.cgi?id=16731

Attachment 18302: proposed fix
http://bugs.webkit.org/attachment.cgi?id=18302&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I do not quite understand the theory behind this, but the change looks
straightforward.

Note that parsing a whole document is different from parsing a fragment for
some reason. In the former case, we get "characters" callbacks, and do not need
to handle ignorableWhitespace - yet for fragments, it seems necessary.


More information about the webkit-reviews mailing list