[webkit-reviews] review granted: [Bug 16748] DOMRange.cloneContents does not work (Acid3 bug) : [Attachment 18297] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 6 03:04:05 PST 2008

Darin Adler <darin at apple.com> has granted Andrew Wellington
<proton at wiretapped.net>'s request for review:
Bug 16748: DOMRange.cloneContents does not work (Acid3 bug)

Attachment 18297: Proposed patch

------- Additional Comments from Darin Adler <darin at apple.com>
There's no need to call fragment.release() if you're not returning the
fragment. A plain old "return 0" will do, and it's more efficient.

Otherwise looks great.

I'll say review+, but really those extra fragment.release() calls should not be
in there.

More information about the webkit-reviews mailing list