[webkit-reviews] review requested: [Bug 16749] DOMRange.surroundContents throws wrong exception (Acid3 bug) : [Attachment 18294] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 5 20:27:41 PST 2008

Andrew Wellington <proton at wiretapped.net> has asked  for review:
Bug 16749: DOMRange.surroundContents throws wrong exception (Acid3 bug)

Attachment 18294: Proposed patch

------- Additional Comments from Andrew Wellington <proton at wiretapped.net>
Ensure that we throw for all non-text nodes not just those that aren't
character indexed for offsets.

Also moved the code for this exception up the method so it'll throw before
HIERARCHY_REQUEST_ERR, which will let this Acid3 test pass.

More information about the webkit-reviews mailing list