[webkit-reviews] review requested: [Bug 16202] Optimize allocation of ActivationImp objects : [Attachment 18292] Revised proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 5 18:26:15 PST 2008


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 16202: Optimize allocation of ActivationImp objects
http://bugs.webkit.org/show_bug.cgi?id=16202

Attachment 18292: Revised proposed patch
http://bugs.webkit.org/attachment.cgi?id=18292&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
(In reply to comment #12)
> (From update of attachment 18287 [edit])
> Obviously the commented out printf()s will need to be removed.

Oops! Took those out.

> Also, the
> indenting is incorrect on things like ActivationImp::init, 4 spaces instead
of
> 2.

There might be an indentation problem somewhere, due to the inconsistent
indentation throughout JSC, but I used 2 spaces for ActivationImp::init.

> Single line ifs are two lines:
> if (!switchGlobal) exec->dynamicGlobalObject()->tearOffActivation(exec);

Fixed.

> You should read: http://webkit.org/coding/coding-style.html

I've read it, but I still occasionally make some mistakes. Sorry.


More information about the webkit-reviews mailing list