[webkit-reviews] review requested: [Bug 16115] [GTK] ContextMenu and ContextMenuItem lacks an implementation : [Attachment 18240] Create the GtkMenuItem on the fly.

[bugzilla-daemon at webkit.org]

Holger Freyther <freyther at handhelds.org> has asked  for review:
Bug 16115: [GTK] ContextMenu and ContextMenuItem lacks an implementation
http://bugs.webkit.org/show_bug.cgi?id=16115

Attachment 18240: Create the GtkMenuItem on the fly.
http://bugs.webkit.org/attachment.cgi?id=18240&action=edit

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
This patch creates the GtkMenuItem on the fly. This allows to change the type,
title and action easily. These values can be populated from an existing
GtkMenuItem, e.g. when an item has been activated.

ContextMenuItem::setChecked is a pretty bad for the Gtk+ platform. We must know
if an item is supposed to be checkable or not as we have GtkMenuItem and
GtkCheckMenuItem and both get drawn differently. We should add another
ActionType for checkable menuitems and make use of them.