[webkit-reviews] review denied: [Bug 14809] [gtk] Implement settings as properties of WebKitGtkPage : [Attachment 18194] Updated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 1 23:01:37 PST 2008


Alp Toker <alp at atoker.com> has denied Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 14809: [gtk] Implement settings as properties of WebKitGtkPage
http://bugs.webkit.org/show_bug.cgi?id=14809

Attachment 18194: Updated
http://bugs.webkit.org/attachment.cgi?id=18194&action=edit

------- Additional Comments from Alp Toker <alp at atoker.com>
Thanks Christian for getting this patch back in action.

There's been some good discussion over the merits of having settings on WebView
vs. a separate settings object and I think we should go for the latter now.

So it's best to have these properties on WebKitWebSettings.

As you suggested, we can look into having them on both objects later on. There
are a couple of techniques we can use to do this, but I don't think we should
do it just yet.


More information about the webkit-reviews mailing list