[webkit-reviews] review requested: [Bug 16545] KJS::Bindings::Instance type conversions are not safe if multiple language bindings are used : [Attachment 18231] Slightly different patch - don't bother returning Instance*

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 1 21:09:39 PST 2008


Michael Goddard <michael.goddard at trolltech.com> has asked  for review:
Bug 16545: KJS::Bindings::Instance type conversions are not safe if multiple
language bindings are used
http://bugs.webkit.org/show_bug.cgi?id=16545

Attachment 18231: Slightly different patch - don't bother returning Instance* 
http://bugs.webkit.org/attachment.cgi?id=18231&action=edit

------- Additional Comments from Michael Goddard
<michael.goddard at trolltech.com>
For simpler code, don't return the Instance* when all anyone ever does with it
is to return the native void* that it wrapped.	This does add a void* member to
Instance, but this is useful for more than just this purpose (I have a patch
for caching JSObject/Instance * for the same native object*, for example).


More information about the webkit-reviews mailing list