[webkit-reviews] review granted: [Bug 16695] JSC allows non-identifier codepoints in identifiers (Acid3 bug) : [Attachment 18227] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 1 12:55:31 PST 2008

Eric Seidel <eric at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 16695: JSC allows non-identifier codepoints in identifiers (Acid3 bug)

Attachment 18227: patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
1.  I'm confused by your testing of \u vs \\u at the end
shouldBe("var test = { }; test.i= 0; test.i\u002b= 1; test.i;", "1");
The fact that that is supposed to work and \\u isn't, confuses me, and calls
into question all the other \\u tests above
I guess I'm just not sure what '\u' would be interpreted as, and why it's a
valid identifier char.
2.  I don't see a test for valid identifier part unicodes used at a identifier
3.  it looks like the logic for checking \u could be squashed into the two
"call sites" instead of making a new state
(which would be faster, and fewer states)

Assuming you address those comments via IRC or here, the patch looks great. :) 
Marking r+ since I don't need to see another patch.

More information about the webkit-reviews mailing list