[webkit-reviews] review denied: [Bug 16676] Apply GTK coding style to WebKit Gtk : [Attachment 18191] Apply GTK coding style

[bugzilla-daemon at webkit.org]

Alp Toker <alp at atoker.com> has denied Michael Natterer <mitch at imendio.com>'s
request for review:
Bug 16676: Apply GTK coding style to WebKit Gtk
http://bugs.webkit.org/show_bug.cgi?id=16676

Attachment 18191: Apply GTK coding style
http://bugs.webkit.org/attachment.cgi?id=18191&action=edit

------- Additional Comments from Alp Toker <alp at atoker.com>
Mitch,

I've been thinking about this one the last couple of days.

There are two reasons why I don't think we should do this (yet):

(1) The patch makes indentation dependent on the length of various types names
and variables names that we're planning to change pretty soon. So it would make
future patches much larger than necessary. We want to keep patches as small as
possible to ease reviewing and to ease merging, since several developers
currently maintain their own branches and push regularly.

(2) The Apple guys often help out in maintaining this code, which is very
valuable to the GTK+ port. I think they'd be less likely to casually fix our
build if they had to mess about with whitespace in surrounding unrelated lines.


The GTK+ coding style is more aesthetic but I don't think it's worthwhile given
these factors.

It may make sense to apply the header changes after the API has stabilised.

It probably makes sense to apply the part of the patch to GtkLauncher's main.c
right now. I can apply a reduced version of the patch to do that if you like.