[webkit-reviews] review requested: [Bug 14730] [curl] Cookie handling : [Attachment 19465] Rewritten patch addressing Marc's comments

[bugzilla-daemon at webkit.org]

Julien Chaffraix <julien.chaffraix at gmail.com> has asked  for review:
Bug 14730: [curl] Cookie handling
http://bugs.webkit.org/show_bug.cgi?id=14730

Attachment 19465: Rewritten patch addressing Marc's comments
http://bugs.webkit.org/attachment.cgi?id=19465&action=edit

------- Additional Comments from Julien Chaffraix <julien.chaffraix at gmail.com>
It took me some time but I have rewritten most of the first patch. It had too
many issues to be really usable : Marc pointed some but there were others.

The new one should address all the comments : 
- for the date issue, I have used curl_getdate as ICU data parsing was way too
simple for processing cookies' date.
- the cookies are saved in a sqlite table
- they are saved as soon as they are processed (instead on waiting for the
destructor)
- the methods take "const String&" to prevent content's copy

I have added some features :
- we have a real parser that is RFC2109 compliant (with some Mozilla hacks)
- LRU replacement policy for cookies (as required per RFC2109)

The patch is quite huge and if necessary, I should be able to cut it to several
pieces to ease review.