[webkit-reviews] review cancelled: [Bug 15754] webarchive layout tests fail when WebKit directory path contains symlinks : [Attachment 19422] Patch v1

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has cancelled David Kilzer
(ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 15754: webarchive layout tests fail when WebKit directory path contains
symlinks
http://bugs.webkit.org/show_bug.cgi?id=15754

Attachment 19422: Patch v1
http://bugs.webkit.org/attachment.cgi?id=19422&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
(In reply to comment #4)
> This patch looks OK to me, but I don't think it will fix the whole problem:
> there are a few webarchive tests that are not located in
> LayoutTests/webarchive. For example, there are svg webarchive tests.

Thanks for catching this.  I fixed this by searching backwards in the URL for
"/LayoutTests/" instead of searching forward for "/LayoutTests/webarchive/". 
Assuming we never create any subdirectories named "LayoutTests" under
"LayoutTests" with webarchive tests in them, this will just work!

I also ran all of the layout tests this time.  The SVG tests did fail with the
previous patch.  They all pass now with this patch, as do
LayoutTests/webarchive.

Sorry it took so long to fix this.