[webkit-reviews] review requested: [Bug 13031] onkeydown prevents keyboard shortcuts from working on this page when the input field had focus. : [Attachment 19411] First attempt (fix + manual test)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 27 15:09:01 PST 2008


Julien Chaffraix <julien.chaffraix at gmail.com> has asked  for review:
Bug 13031: onkeydown prevents keyboard shortcuts from working on this page when
the input field had focus.
http://bugs.webkit.org/show_bug.cgi?id=13031

Attachment 19411: First attempt (fix + manual test)
http://bugs.webkit.org/attachment.cgi?id=19411&action=edit

------- Additional Comments from Julien Chaffraix <julien.chaffraix at gmail.com>
The issue is in WebHTMLView performKeyEquivalent, ret is set to YES which
prevent the keyboard shortcut to work. So if WebCore has handled or cancelled
the event (ret is YES), force the value to be NO but only for events with the
Command flag.


More information about the webkit-reviews mailing list