[webkit-reviews] review denied: [Bug 14348] Messing up the inspector by dragging an URL into it : [Attachment 19369] revised patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has denied Matt Lilek
<webkit at mattlilek.com>'s request for review:
Bug 14348: Messing up the inspector by dragging an URL into it
http://bugs.webkit.org/show_bug.cgi?id=14348

Attachment 19369: revised patch
http://bugs.webkit.org/attachment.cgi?id=19369&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
+    , m_delegate(new WebInspectorDelegate())

I don't think there's any need for the WebInspectorClient to hold onto the
delegate.

+class WebInspectorDelegate : public IWebUIDelegate {
+public:
+    WebInspectorDelegate();

Our COM classes normally have a private constructor/destructor and a static
createInstance() method that returns a new instance with a refcount of 1. You
should make this class follow that pattern.

Other than those comments, this looks good to me. r- so we can get those things
fixed up.