[webkit-reviews] review granted: [Bug 17487] HTMLInput mysteriously fails to work if ICU dat file is missing : [Attachment 19399] Patch from svn-create-patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 27 07:54:09 PST 2008
Alexey Proskuryakov <ap at webkit.org> has granted Sriram Neelakandan
<sriram.neelakandan at gmail.com>'s request for review:
Bug 17487: HTMLInput mysteriously fails to work if ICU dat file is missing
http://bugs.webkit.org/show_bug.cgi?id=17487
Attachment 19399: Patch from svn-create-patch
http://bugs.webkit.org/attachment.cgi?id=19399&action=edit
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
There are still some issues with this patch, but I'm going to say r=me and fix
those when landing.
1. There is no ChangeLog.
2. "+#include <stdio.h>" is no longer needed without fprintf.
3.
+ if (!createdIterator)
+ {
We put opening brace on the same line as "if".
4. Instead of a combination of LOG_ERROR and ASSERT, one can use
ASSERT_WITH_MESSAGE.
More information about the webkit-reviews
mailing list