[webkit-reviews] review requested: [Bug 16815] Crash with navigator.plugins and navigator.mimeTypes after plugins.refresh : [Attachment 19375] new patch including Gtk+ Automake build fix and more coding style fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 26 08:19:08 PST 2008


Simon Hausmann <hausmann at kde.org> has asked  for review:
Bug 16815: Crash with navigator.plugins and navigator.mimeTypes after
plugins.refresh
http://bugs.webkit.org/show_bug.cgi?id=16815

Attachment 19375: new patch including Gtk+ Automake build fix and more coding
style fixes
http://bugs.webkit.org/attachment.cgi?id=19375&action=edit

------- Additional Comments from Simon Hausmann <hausmann at kde.org>
Thanks for the suggestions, I've added them to this latest patch.

I wanted to change the inclusions of PassRefPtr.h to Forward.h, but realized it
doesn't work because the inline create() function that replaces the constructor
uses adoptRef, which calls actually functions on PassRefPtr.


More information about the webkit-reviews mailing list