[webkit-reviews] review denied: [Bug 17538] Can't build CollectorHeapIntrospector.cpp as a standalone file outside of AllInOneFile.cpp : [Attachment 19355] Move the definition of CollectorHeap into collector.h, and provide a "using" declaration for WTF::RemoteMemoryReader

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 25 14:26:47 PST 2008


Mark Rowe (bdash) <mrowe at apple.com> has denied Mark Mentovai
<mark at moxienet.com>'s request for review:
Bug 17538: Can't build CollectorHeapIntrospector.cpp as a standalone file
outside of AllInOneFile.cpp
http://bugs.webkit.org/show_bug.cgi?id=17538

Attachment 19355: Move the definition of CollectorHeap into collector.h, and
provide a "using" declaration for WTF::RemoteMemoryReader
http://bugs.webkit.org/attachment.cgi?id=19355&action=edit

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
The patch looks good to me, but it will need a ChangeLog before it can be
landed.  Please see the instructions at
<http://webkit.org/coding/contributing.html> and attach an updated patch with a
ChangeLog entry for JavaScriptCore.


More information about the webkit-reviews mailing list