[webkit-reviews] review denied: [Bug 17186] Fragment navigations within a page permanently cancels scheduled meta-refreshes : [Attachment 19334] patch with regression test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 24 21:01:14 PST 2008


Darin Adler <darin at apple.com> has denied 's request for review:
Bug 17186: Fragment navigations within a page permanently cancels scheduled
meta-refreshes
http://bugs.webkit.org/show_bug.cgi?id=17186

Attachment 19334: patch with regression test
http://bugs.webkit.org/attachment.cgi?id=19334&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Here's a patch that includes a regression test. However, I'm almost certain
this fix is incorrect. There are two things wrong with it:

    1) The m_sentRedirectNotification flag is not the right thing to look at.
That flag has a specific purpose relating to sending notifications to the
FrameLoaderClient, and this is not an appropriate use of it.

    2) Forcing a reload is not the correct behavior. We don't want to stop the
meta refresh, but we also don't want to do a reload of the page for the same
reason we don't reload other times.

I'll investigate other fixes.


More information about the webkit-reviews mailing list