[webkit-reviews] review granted: [Bug 17444] nested script inside external script cause error : [Attachment 19226] patch v1 for fixing this problem

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 24 18:07:26 PST 2008


Darin Adler <darin at apple.com> has granted johnnyding
<johnnyding.webkit at gmail.com>'s request for review:
Bug 17444: nested script inside external script cause error
http://bugs.webkit.org/show_bug.cgi?id=17444

Attachment 19226: patch v1 for fixing this problem
http://bugs.webkit.org/attachment.cgi?id=19226&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good to me.

+  <head>
+    <title></title>
+  </head>

Seems like we could just omit this whole section.

+    </div>

There's no <div> for this to close.

+document.write("SUCCESS (1 of 2)\n");
\ No newline at end of file

Would have been better having a newline at the end of this file.

r=me even without these changes


More information about the webkit-reviews mailing list