[webkit-reviews] review granted: [Bug 17331] Change postMessage/MessageEvent to match HTML5 wrt. exposing origin vs. domain/uri : [Attachment 19311] Updated patch with origin check moved to DOMWindow

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Collin Jackson
<collinj-webkit at collinjackson.com>'s request for review:
Bug 17331: Change postMessage/MessageEvent to match HTML5 wrt. exposing origin
vs. domain/uri
http://bugs.webkit.org/show_bug.cgi?id=17331

Attachment 19311: Updated patch with origin check moved to DOMWindow
http://bugs.webkit.org/attachment.cgi?id=19311&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
There are a few remaining but this looks really good. 

There is a tab here
+	     String message = String::format("Unable to post message to %s.
Recipient has origin %s.\n", 
+		origin.utf8().data(), actualTargetOrigin.utf8().data());

This should have a raises(DOMException);
+	 [DoNotCheckDomainSecurity, Custom] void postMessage(in DOMString
message, in [Optional] DOMString origin);

This method could be made more efficient by calling reserveCapacity on the
result vector.
+String KURL::origin() const

r=me