[webkit-reviews] review granted: [Bug 17210] Eliminate platform-specific #ifdefs in ResourceError.h and AuthenticationChallenge.h : [Attachment 19285] patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 23 09:28:45 PST 2008


Darin Adler <darin at apple.com> has granted MorganL <morganl.webkit at yahoo.com>'s
request for review:
Bug 17210: Eliminate platform-specific #ifdefs in ResourceError.h and
AuthenticationChallenge.h
http://bugs.webkit.org/show_bug.cgi?id=17210

Attachment 19285: patch v2
http://bugs.webkit.org/attachment.cgi?id=19285&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
One thing I don't like about this approach is that we end up with so many
identically named files in different directories. But it looks like you
executed the design just fine.

r=me


More information about the webkit-reviews mailing list