[webkit-reviews] review requested: [Bug 17481] Several consecutive calls to XMLHttpRequest::open should dispatch only one readyState event : [Attachment 19295] patch updated with Ap's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 23 06:02:04 PST 2008


Julien Chaffraix <julien.chaffraix at gmail.com> has asked  for review:
Bug 17481: Several consecutive calls to XMLHttpRequest::open should dispatch
only one readyState event
http://bugs.webkit.org/show_bug.cgi?id=17481

Attachment 19295: patch updated with Ap's comments
http://bugs.webkit.org/attachment.cgi?id=19295&action=edit

------- Additional Comments from Julien Chaffraix <julien.chaffraix at gmail.com>
> The type of this variable should be XMLHttpRequestState.

changed.

> Looks like it should be "calling open several times in a row". Also, it's
> better to put a period at the end of the sentence.

Changed words' order and added a period.

I also updated the test case so that the result is more human readable.


More information about the webkit-reviews mailing list