[webkit-reviews] review granted: [Bug 17486] Support HTML5 Canvas.getImageData API : [Attachment 19283] getImageData Redux

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 22 16:07:17 PST 2008


Sam Weinig <sam at webkit.org> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 17486: Support HTML5 Canvas.getImageData API
http://bugs.webkit.org/show_bug.cgi?id=17486

Attachment 19283: getImageData Redux
http://bugs.webkit.org/attachment.cgi?id=19283&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
r+ but please 
+    else
+	 return jsUndefined();
remove this else and
+    JSCanvasPixelArray* ret =
static_cast<JSCanvasPixelArray*>(ScriptInterpreter::getDOMObject(pixels));
remove this cast and
remove the implementation of putImageData.


More information about the webkit-reviews mailing list