[webkit-reviews] review granted: [Bug 17481] Several consecutive calls to XMLHttpRequest::open should dispatch only one readyState event : [Attachment 19266] patch + test case

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Julien Chaffraix
<julien.chaffraix at gmail.com>'s request for review:
Bug 17481: Several consecutive calls to XMLHttpRequest::open should dispatch
only one readyState event
http://bugs.webkit.org/show_bug.cgi?id=17481

Attachment 19266: patch + test case
http://bugs.webkit.org/attachment.cgi?id=19266&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me, with comments.

+    int previousState = m_state;

The type of this variable should be XMLHttpRequestState.

+    // Check previous state to avoid dispatching readyState event
+    // when calling several times open in a row

Looks like it should be "calling open several times in a row". Also, it's
better to put a period at the end of the sentence.