[webkit-reviews] review denied: [Bug 16924] Shared PluginDatabase, PluginPackage, and PlugInInfoStore Implementations : [Attachment 19142] Updated patch per Jon's comments

[bugzilla-daemon at webkit.org]

Jon Honeycutt <jhoneycutt at apple.com> has denied Rodney Dawes
<dobey at wayofthemonkey.com>'s request for review:
Bug 16924: Shared PluginDatabase, PluginPackage, and PlugInInfoStore
Implementations
http://bugs.webkit.org/show_bug.cgi?id=16924

Attachment 19142: Updated patch per Jon's comments
http://bugs.webkit.org/attachment.cgi?id=19142&action=edit

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
PluginView::determineQuirks() on Windows uses
PluginPackage::compareFileVersion(), which is no longer available.

I think there should be a cross-platform abstraction for a module version, even
if it's only used on Windows for now. I think it's likely that other platforms
will eventually have the same uses for it that Windows has: preferring the
latest version of several installed plug-ins that handle the same MIME type, or
determining plug-in idiosyncrasies specific to only some versions.

My suggestion is then:

#if PLATFORM(WIN)
typedef struct { unsigned leastSig; unsigned mostSig; } PlatformModuleVersion;
#else
typedef unsigned PlatformModuleVersion;
#endif

int PluginPackage::compareFileVersion(int, int) const ->
int PluginPackage::compareModuleVersion(const PlatformModuleVersion&) const

etc. Does this seem like a good idea to you?

r- for the build breakage mentioned above.