[webkit-reviews] review granted: [Bug 16753] date set methods with no args should result in NaN (Acid3 bug) : [Attachment 19214] Patch to handle NaN, Inf and missing arguments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 20 09:37:56 PST 2008


Darin Adler <darin at apple.com> has granted Michael Knaup
<michael.knaup at mac.com>'s request for review:
Bug 16753: date set methods with no args should result in NaN (Acid3 bug)
http://bugs.webkit.org/show_bug.cgi?id=16753

Attachment 19214: Patch to handle NaN, Inf and missing arguments
http://bugs.webkit.org/attachment.cgi?id=19214&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    if (3 == numArgsToUse && isnan(milli))

I know that in some projects people think that putting the constant on the left
side of an "==" is good style because it helps you avoid the mistake of using
"=" by mistake, but we really don't believe in that, and I think it's strange
to have this once instance of it mixed in with the other code.

The test is great. It's thorough. I'd prefer it if a lot more of the test cases
and results were written out; it's better if the results file shows a lot more
of what's being tested rather than just the conclusions.

If you look at other tests that make heavy use of shouldBe you'll see how that
can work.

+function makeIEHappy (functionNameRoot, value)

We don't put spaces after function names.

+function testDateFunctionWithValueExpectingNaN1(functionNameRoot) {

We put the braces on the next line, not the same line as the function.

r=me as-is, but please consider making improvements as well.


More information about the webkit-reviews mailing list