[webkit-reviews] review requested: [Bug 12751] DocumentType nodes aren't part of the Document (affects Acid3) : [Attachment 19221] Ready for review.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 20 01:21:06 PST 2008


Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 12751: DocumentType nodes aren't part of the Document (affects Acid3)
http://bugs.webkit.org/show_bug.cgi?id=12751

Attachment 19221: Ready for review.
http://bugs.webkit.org/attachment.cgi?id=19221&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This patch has been through the layout tests.  Many tests are changing results:


(1) DOM tests that failed are now passing and/or changing results slightly.
(2) about:blank is now properly in quirks mode instead of strict mode (affects
every single test that uses about:blank)
(3) Positional dumping tests now change when a doctype is placed before the
root element
(4) XSL transform results now have the correct mode

One major change I had to make is that the construction of the style selector
is now delayed until a Document is attached.  Document construction time was
too early, since the compat mode had not yet been initialized (the HTMLDocument
is not even constructed yet in the base class constructor).


More information about the webkit-reviews mailing list