[webkit-reviews] review denied: [Bug 8749] XBM rendered incorrectly as black on white : [Attachment 19156] xbm image creation patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Michael Knaup
<michael.knaup at mac.com>'s request for review:
Bug 8749: XBM rendered incorrectly as black on white
http://bugs.webkit.org/show_bug.cgi?id=8749

Attachment 19156: xbm image creation patch
http://bugs.webkit.org/attachment.cgi?id=19156&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good to me.

For compatibility with 64-bit, instead of float it should be CGFloat.

This is really a workaround for a Radar bug: <rdar://problem/3922468> browsers
treat XBM images as black on transparent background, ImageIO decodes as black
on white

review- because this won't compile 64-bit.