[webkit-reviews] review granted: [Bug 17269] Deobfuscate CanvasRenderingContext2D.cpp : [Attachment 19150] De-ifdefify drawing a canvas to a canvas

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Oliver Hunt <oliver at apple.com>'s request for
review:
Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
http://bugs.webkit.org/show_bug.cgi?id=17269

Attachment 19150: De-ifdefify drawing a canvas to a canvas
http://bugs.webkit.org/attachment.cgi?id=19150&action=edit

------- Additional Comments from mitz at webkit.org
Given that you are adding

+ImageBuffer* HTMLCanvasElement::buffer() const
+{
+    if (!m_createdDrawingContext)
+	 createDrawingContext();
+    return m_data.get();
+}

I think you should change HTMLCanvasElement::drawingContext() to a simple
"return buffer()->context();".

It seems odd that you null-check context in GraphicsContext::paintBuffer() but
not in GraphicsContext::drawImage().

This is rather pointless:

+    CGContextRef platformContext = this->platformContext();

Finally,

+	 // Slow path, boo!

We talked about how it can be made more efficient. You can add a FIXME in
addition or instead of the above comment.

r=me