[webkit-reviews] review granted: [Bug 17360] REGRESSION: mp4 file downloaded from server is downloaded as html : [Attachment 19134] Ignore Content-Type: text/plain if the extension is of a non-textual type

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted mitz at webkit.org's request for
review:
Bug 17360: REGRESSION: mp4 file downloaded from server is downloaded as html
http://bugs.webkit.org/show_bug.cgi?id=17360

Attachment 19134: Ignore Content-Type: text/plain if the extension is of a
non-textual type
http://bugs.webkit.org/attachment.cgi?id=19134&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me, with comments.

+ * Copyright (C) 2008 Apple Inc. All rights reserved.

I think we need a three-clause license, such as the one in WebTextRenderer.h.

+static NSSet *createBinaryExtensionsSet()

Where does this list come from? Could you add .eps, .ps, .ttf, .otf, .pfa,
.pfb, .qxp, .indd, .ai, to make publishing folks a little happier?

+	 return [binaryExtensions containsObject:[[self suggestedFilename]
pathExtension]] ? MIMEType : @"text/plain";

Is there lowercasing performed in some place that I missed?